Closed dpinney closed 9 years ago
Assigned Mannan.
Implementation of this is ready for testing in production.
Version without checkbox functionality committed. It emails the user by default right now. I'll commit a version with checkbox selection asap.
Could we move the checkbox up with the other shortInput fields (yellow box in attached)? And not have the line break after zip code?
Email fine where it is. Mannan is going to close up the space marked in yellow.
Changes done, and committed.
Shouldn't be closed yet, still have to implement checkbox functionality.
Now commited.
Looks like this:
Nice. Let's leave this open until we confirm the emailing functionality works.
Got a problem with the omf import and this new code.
If I make a file like:
import omf
print 'yo'
And run I get the following error:
Traceback (most recent call last):
File "/Users/dpinney/Desktop/test.py", line 1, in <module>
import omf
File "/Users/dpinney/Dropbox/omf/omf/__init__.py", line 14, in <module>
import models
File "/Users/dpinney/Dropbox/omf/omf/models/__init__.py", line 14, in <module>
for name in __all__: exec('import ' + name)
File "<string>", line 1, in <module>
File "/Users/dpinney/Dropbox/omf/omf/models/gridlabMulti.py", line 18, in <module>
from web import send_link
File "/Users/dpinney/Dropbox/omf/omf/web.py", line 8, in <module>
import models, feeder, milToGridlab
File "/Users/dpinney/Dropbox/omf/omf/models/__init__.py", line 14, in <module>
for name in __all__: exec('import ' + name)
File "<string>", line 1, in <module>
File "/Users/dpinney/Dropbox/omf/omf/models/gridlabMulti.py", line 18, in <module>
from web import send_link
ImportError: cannot import name send_link
[Finished in 0.7s with exit code 1]
[shell_cmd: python -u "/Users/dpinney/Desktop/test.py"]
[dir: /Users/dpinney/Desktop]
[path: /usr/bin:/bin:/usr/sbin:/sbin]
Maybe a circular import?
Could be; I installed the various packages & dependencies seperately so I can't import omf (or just not sure how to if I can). Can it be built on Linux so I can test this?
I can reproduce the issue on Linux with the same script as above. This used to work.
I fixed the circular import issue. Commit 70dd2ce028e79c5a7d2b570b1ef5d5abcf736216
Documentation: http://stackoverflow.com/a/22210807
Great. Thanks for the reference.
Assigned to david to test in production
This works perfectly in production. Closing the issue.
TODO
Only for long-running models like Gridlab.