Fix every #TODO

[dpinney]

There are a bunch of TODO comments in the code. Let's fix the issues.

[srivats0603]

A question: filename: init.py ; function _strClean(x) TODO was to write tests for this function. I partially understand the purpose of this function, it is to convert a number 'x' written in some format to a float value. I need more clarification on this. Specifically, what is the expected output for different input formats. Or what are the valid input formats??

Test case 1: I tested it as a separate function with two different inputs: (1) 22.5_1e10: Output is same as input string : 22.5_1e10 (2) 22.5e10 output is: 2.25e11

Is this the expected outcome?

[srivats0603]

What was the purpose of this design: every string ending with 'd' would return a zero?

One crazy test case (probably not required): input: 40$ -> output: 40$ input: 40 usd -> output: 0.0

[dpinney]

Leave _strClean to me. It handles specific Gridlab-D formatting.

[srivats0603]

CVR static.py. Line 262 TODO item: we can probably get this PF data from the Milsoft loads.

Question: Is this issue solved by making power factor user configurable? If yes, then we can remove this TODO item after the fixes today.

[dpinney]

Re: power factor, check in the Milsoft docs whether they have per-load, per-meter or per-transformer power factor data. It looks like my links to the docs were broken when Milsoft redesigned their website. :rage:

[dpinney]

Note: the more I look at the list of todos, the more I think a lot of them are not high priority. If anyone can fix a todo quick, go for it. Otherwise wait for me to remove the one's that we don't need to complete this quarter.

[dpinney]

All todos in milToGridlab.py are low priority.

[dpinney]

We must ignore every todo in /omf/calibration/ and /omf/scratch/

[dpinney]

We're done. For the last two issues, because they're big, there are now #206 and #207