New models with same name as existing results in data loss.

[dpinney]

TODO

• When model is created, use omf.web.uniqObjName to check for uniqueness, tell the user when their name isn't unique, alert and tell the user to choose a different name.

POSSIBLE OPTIONS

• Later option: getUniqObjName function.
• Changing names = IOError. Solution: make changing model name in stopped/running/finished states impossible.
• Creating new model with same name as old. Solution: check in javascript when validating the form using AJAX request to /uniqObjName/model//
• Think about checking in web.py instead when creating models. Be careful about re-running models.

[dpinney]

Good enough for now. Future event.

[dpinney]

@jinhw1989 doesn't need to worry about this.

[dpinney]

Mannan assigned.

[mannanj]

I think this is ready to go!

Error looks like:

Made a change to the runButton in PVWatts ( as an example) so it runs the following javascript before submitting the form: (added to models.js since it will eventually be used in every model):

function checkModelName() {
    var newName = modelName.value
    $.ajax({
        url: "/uniqObjName/Model/" + currentUser + "/" + newName
    }).done(function (data) {
        if (data.exists) {
            alert("You already have a Model named " + newName)
        }
        else{   
            inputForm.submit()          
        }
    })  
}

runButton change:

<button id="runButton" type="button" class="preRun" onclick="javascript:checkModelName()">Run Model</button>

[dpinney]

Looks nice and clean.

If it tests okay with pvWatts, let's slap it on the models.

One change, for the error message:

alert("You already have a Model named '" + newName + "', please choose a different name.")

[dpinney]

Oh, and by the way, triple backticks on github put your code in fixed width font. I added that to your comment above.

[mannanj]

Oh that looks a lot better, thanks!

I'll update the rest of the models and commit.

[mannanj]

Now updated and closed.

[mannanj]

This was interfering with input validation, fixed this in commit 7ffc6e6cce40f4a9ede521224e3cae0f0997c46e

[dpinney]

Reopened.

[dpinney]

Fixed and production updated!

[mannanj]

The commit where this was fixed is 66155a5f6cc5d20d96afedc2b736619594d1c62a