dpinney / omf

The Open Modeling Framework for smart grid cost-benefit analysis.
https://omf.coop
GNU General Public License v2.0
112 stars 60 forks source link

Cyme conversion lat/lon child node improvements. #266

Closed dpinney closed 10 years ago

dpinney commented 10 years ago

First off, @afisher1, the conversion code you delivered works, was right on schedule, and the code quality is excellent.

One issue: some child nodes are given (0,0) as their x/y coordinates (in the gld lat/lon properties). Image showing this below. How much work would it take to make sure they're placed near their parents?

image

jcfuller1 commented 10 years ago

@dpinney , What if we started by using the parent's (x,y) coordinate, then added a little offset? May have to play with the offset a little to make it look visually appealing, but that would put it in the right ballpark.

dpinney commented 10 years ago

Small random offset from parent would be a perfect solution. It looks like all the things at (0,0) are triplex_node objects, so the fix is probably quick and easy (parent explicitly referenced instead of having to find everything attached to a from-to link).

afisher1 commented 10 years ago

Wow. I'm taking a look at this now to see what caused this. I do remember copying parent x/y information to load objects.

dpinney commented 10 years ago

I added the .py code to /omf/omf/cymeToGridlab.py. I'm keeping the .glm output and .mdb stuff off github, but can we keep that cymeToGridlab.py file up to date?

afisher1 commented 10 years ago

Ok sounds good to me. What do you expect lat lon information on besides nodes, meters, loads, triplex_meters, and loads? Capacitors? Links?

dpinney commented 10 years ago

Lat Lon info only needed for node-like objects and not for link-like ones.

The configuration objects can all be put at random lat/Lon's clustered around (0,0).

afisher1 commented 10 years ago

Fixes made. @dpinney can you check how the out put looks now?

dpinney commented 10 years ago

Beautiful.

image