Improved location indicator for solarFinancial.

dpinney / omf

The Open Modeling Framework for smart grid cost-benefit analysis.

https://omf.coop

GNU General Public License v2.0

112 stars 60 forks source link

Improved location indicator for solarFinancial. #279

Closed dpinney closed 9 years ago

dpinney commented 9 years ago

TODO

Move the zipcode mapping stuff to weather.py.
Add the zip code logic to the other solar models.

QUESTIONS

Currently users can only specify a solar model location by choosing a TMY file. Ideally, we want to allow them to choose either a zipcode or a lat/lon pair or a TMY location.

dpinney commented 9 years ago

Design sketch of the ultimate location chooser:

mannanj commented 9 years ago

So climatename selection has been replaced with zipcode input for all models. I believe we agreed on taking out lat/lon.

dpinney commented 9 years ago

Yeah, let's leave off lat/lon.

dpinney commented 9 years ago

Code looks pretty good. We need a test for zipCodeToClimateName. Also, imports need to go at the top of the file and not in the function definition. It's a python convention.

mannanj commented 9 years ago

Aha I didn't think where the import is would matter if it isn't used much. Imports have been moved, and a test case added under weather.py. With that this issue is closed.

dpinney commented 9 years ago

This work had some problems: excess code that never ran (second return statement), print statements in non-test code (wrong data for server logs), _tests failed on the metamodel import. I fixed this in c2623dc1ecf6478ba452ec13a1dc7010b845e92b.