dpinney / omf

The Open Modeling Framework for smart grid cost-benefit analysis.
https://omf.coop
GNU General Public License v2.0
112 stars 60 forks source link

energyStorage Enhancements #351

Closed dpinney closed 9 years ago

dpinney commented 9 years ago

TODO

dpinney commented 9 years ago

Hey Mannan, could we add this todo item to your issue list? No need to worry about the questions for now or the hard to implement parts of the linked document.

mannanj commented 9 years ago

Sure can. I expect I'll look into the model over the weekend and the feedback Monday; will direct any questions to you guys then.

dpinney commented 9 years ago

Sounds good. Thanks.

mannanj commented 9 years ago

Update on the features @drdanley feedback file/ todo list that are done (results shown in the screenshots below).

What is not done is: Input Screen: #3, #7, #8 (file bug). #6 is complicated and per a prior conversation with David will be considered later. #7 is quick and easy, all we need is a good default electricity cost for recharging the batteries.

Results: #1 skipped by design decision (redisplaying inputs was seen as redundant). #2 is done except I could not find a well cited degradation figure on Tesla's powerwall battery which I believe we wanted to use here (I am using 80% degredation at 5000 cycles which was quoted from a website without a citation but then again Tesla hasn't released their powerwall specification sheet but I think this 80% figure was taken from the model S).

3 I added information on the battery to the demand chart so you can zoom and see specific battery use there, but does this offer the same functionality?

5 skipped due to design choice.

Algorithm: All skipped til future date.

energystoragedemand energystoragesoccashflow energystoragetop

dpinney commented 9 years ago

Screenshots look great.

You're still working on #3, #7, and #8, right?

Default demand charge should be $10/kW. Default cost of electricity for recharging should be 0.07 $/kWh.

(Side note: why do we put the dollar sign in front of numbers instead of after like other units? Because its a security feature. If the dollar sign goes after, its easy to rewrite an amount like 10$ in to 110$. Thanks wikipedia.)

mannanj commented 9 years ago

Yes still working on those. Thanks for answering my questions. Also interesting comment on the $ feature.

3 I am thinking of changing it from "Battery System AC Round Trip Efficiency (%)" to 2 inputs: "Battery Round Trip Efficiency (%)" and "Inverter Efficiency (%)" as Doug mentions. I prefer the 2 input version because it is consistent with the rest of the models.

6 this requires a demand charge example where it varies over the year, when/if we have one the calculation will have to be updated.

7 This will be done now that I have an electricity cost of 0.07 %/kWh

dpinney commented 9 years ago

3 I am thinking of changing... 2 input version because it is consistent with the rest of the models.

Great. That's perfect.

mannanj commented 9 years ago

Alright so lets talk about this monday? If so I'll wait to commit until we've come up with a plan for the rest of the list.

mannanj commented 9 years ago

TODOs: -add background process -for monthly cost table: add x-overflow scroll -demand curve file box issue from docx -send david final docx

mannanj commented 9 years ago

All the prescribed features have now been pushed, and tested working. This can be closed after we review the final .docx and are happy with the results.

mannanj commented 9 years ago

FYI Cancel run doesn't stop it running. Command prompt shows the error:

Fatal Python error: PyEval_RestoreThread: NULL tstate

This application has requested the Runtime to terminate it in an unus Please contact the application's support team for more information.