search

dpinney / omf

The Open Modeling Framework for smart grid cost-benefit analysis.
https://omf.coop
GNU General Public License v2.0
112 stars 62 forks source link

Missing conductors fix #369

Closed kilofarad closed 5 years ago

kilofarad commented 5 years ago

Added a function to milToGridlab.py that fixes the missing conductors (as long as a working conductor exists somewhere in the tree).

dpinney commented 5 years ago

Nice code style. I enjoyed the brother/dotter/grandmother var names. Very clear.

Quick question before I merge: in the omfConversionTesting set (1) how many models have missing conductors and (2) how many of those does this function fix?

kilofarad commented 5 years ago

There are 7 with missing conductors, and, if I remember correctly, this fixes the missing conductor error in 5 of them. Of those 5, 2 of them have phase mismatch errors (so the powerflow still fails). The two that aren't fixed should be fixed once we implement a default underground line conductor that it can pull from.

On Wed, Nov 7, 2018 at 3:03 PM David Pinney notifications@github.com wrote:

Nice code style. I enjoyed the brother/dotter/grandmother var names. Very clear.

Quick question before I merge: in the omfConversionTesting set (1) how many models have missing conductors and (2) how many of those does this function fix?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dpinney/omf/pull/369#issuecomment-436758586, or mute the thread https://github.com/notifications/unsubscribe-auth/AhLIhLMfdGo_moVqx2NIePTE6Dy8ZQD-ks5uszx0gaJpZM4YTIfW .

dpinney commented 5 years ago

Results from omfConversionTesting sound great.

However, there are some indentation issues with your new code (see Travis CI results). Please fix those before we merge this.

dpinney commented 5 years ago

Looks great. Thanks.