search

dpinol / closure-templates

Automatically exported from code.google.com/p/closure-templates
Apache License 2.0
0 stars 0 forks source link

SoyFileSet.Builder#addVolatile is not documented correctly #53

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
VolatileFileVersion is only checked in SoyFileSet#compileToRuntimes. 

This is misleading, callers would expect that calls to compileToTofu would 
return a SoyTofu object that would reload the source .soy files if they changed.

At the very least the javadoc should be updated to reflect this.

As a separate issue, if there's no way to compile SoyTofu objects that can 
reflect edits to their source .soy files, we should add one because restarting 
slows the compile-build-test cycle.

Original issue reported on code.google.com by ori.schw...@gmail.com on 12 Feb 2012 at 12:28

GoogleCodeExporter commented 8 years ago 
Actually there is a TODO comment in SoyFileSet:570, that may indicate that 
checking volatile input when building Tofu-s is planned, just not implemented 
yet:

......
  public SoyTofu compileToTofu(SoyTofuOptions tofuOptions) throws SoySyntaxException {
......
    // TODO: Allow binding a SoyTofu instance to volatile inputs.
    SoyFileSetNode soyTree = (new SoyFileSetParser(soyFileSuppliers)).parse();
.....

As this issue is more than a year old i'm just curious when we can expect this 
to happen.

Original comment by tr...@euedge.com on 13 May 2013 at 2:15

GoogleCodeExporter commented 8 years ago 
Closure Templates has migrated to GitHub: 
https://github.com/google/closure-templates. Please reopen this there if it's 
still an issue.

Original comment by brendan....@gmail.com on 27 Feb 2015 at 12:15