dpjudas / UT99VulkanDrv

Vulkan, Direct3D 11 and Direct3D 12 renderer for Unreal Tournament (UT99)
Other
68 stars 8 forks source link

Max Lighting not getting as bright as the dx9 or xopengl renderer #8

Closed chris-mcc closed 1 year ago

chris-mcc commented 1 year ago

With a new UT99 patch, 469C RC2 being released I've been playing around with the different renderers as they've improved.

I noticed that the max brightness in the Vulkan renderer is lower than the others. They both go correctly completely dark at basically the same point. UT_D3D9 UT_Vulkan

First one is dx9, the second is the vulkcan renderer.

Would this be a white light limit? What do you think?

dpjudas commented 1 year ago

Hmm yeah, you're right. The Direct3D renderer actually doubles the strength of the lightmaps so that they can overbright.

I released a new version that fixes this along with the weapon clipping bug for the redeemer.

chris-mcc commented 1 year ago

Pretty hard to spot the difference now. The shadows seem to be a touch too bright. xopengl_intheshade

vulkan16_intheshade

First is xopengl , second is vulkcan If you look at the box in the bottom right ish you'll notice the shadows are not quite as dark. Not sure why.

Anything spring to mind?

dpjudas commented 1 year ago

I'm afraid not. Only way I can get it a bit closer to that is if I subtract a bit of light for the lightmaps overall.

chris-mcc commented 1 year ago

Ah, so no changiong the rate of decay for the lighting? Mm, I've asked in the discord server if the xopengl renderer does something special.

dpjudas commented 1 year ago

I created a 1.7 release with slightly darker light maps. This is probably about as good as it is going to get. It is quite possible that render device does something special if the D3D ones don't look alike. In any case, I don't know what is different, so I can't fix it.

chris-mcc commented 1 year ago

Oh, I can't tell the difference anymore. That's pretty much spot unless we discover if it does anything special.

I'll have a more complete gander tomorrow.