dpla / dpla-frontend

React application for the Digital Public Library of America website
http://dp.la
MIT License
28 stars 5 forks source link

Fix FILES_ENDPOINT variable in dpla-frontend exhibitions (DT-1812) #486

Closed mgiraldo closed 6 years ago

mgiraldo commented 6 years ago

The {{dpla-frontend}} {{exhibitions}} controller uses a variable, {{FILES_ENDPOINT}}, which governs both the location of the API endpoints and the static files served by the Omeka API server. This does not give us the flexibility we need to serve these assets efficiently. This should be modified to allow {{/api/files}} to be served statically from another location.

Creator: Mark Breedlove Reporter: Mark Breedlove

mgiraldo commented 6 years ago

@markbreedlove is this still an issue?

markbreedlove commented 6 years ago

@mgiraldo I think it's still an issue. The idea is that we want the JSON data about exhibitions pages to come from the Omeka servers, but we might want to serve up the images from a different path where we apply different caching rules. I don't recall exactly how it works at the moment, though, with the Omeka service and the Angular / Next.js frameworks; that's just what I think I was writing about.

mgiraldo commented 6 years ago

i think this is fixed @markbreedlove ?

markbreedlove commented 6 years ago

Yes, I'm seeing now how it's been broken into files and items endpoints.