search

dplassgit / d2lang

D2 is a strongly-typed, statically-typed, (mostly) inferred-type compiled language.
MIT License
7 stars 0 forks source link

Replace "foo" with a more meaningful variable name in the op= parse code #301

Closed dplassgit closed 4 months ago

dplassgit commented 9 months ago

https://github.com/dplassgit/d2lang/blob/58d557408e6ef667cc488742e943e9325022e7d5/src/com/plasstech/lang/d2/parse/Parser.java#L290

724thomas commented 9 months ago

hi, i searched good first issue on explore tab and arrived here :) maybe foo --> binaryOperationResult?

dplassgit commented 9 months ago

hi, i searched good first issue on explore tab and arrived here :) maybe foo --> binaryOpNode?

That's not meaningful. Maybe rename "rhs" to "originalRhs" and "foo" to "newRhs"

ghanghavmayur commented 9 months ago

Sir can you please review PR #308

dplassgit commented 9 months ago

Will do. Note, I am in the Eastern US zone so I may not have time to work on this until much later today.

ghanghavmayur commented 9 months ago

No problem at all, sir! If there's any mistake or if you have any suggestions, please let me know. Your guidance is highly valued.