Rubocop

[dazza-codes]

Adopting style recommendations from https://github.com/sul-dlss/DeveloperPlaybook/tree/master/style.

Applied the auto-correct and checked that specs were passing before and after the corrections.

[malakai97]

Can we configure this to not suppress explicit return statements? These provide useful information.

How does this fit into the workflow?

[dazza-codes]

WRT redundant return

• http://www.rubydoc.info/github/bbatsov/rubocop/Rubocop/Cop/Style/RedundantReturn
• usually an explict return is used as a control structure to return prematurely from a method
• the implicit return of a method is the last statement's return value
• I've generally adopted this practice, even though it was foreign to me when I first moved from python to ruby coding. If there is a way to supress that warning, I've not wanted to use it. I'm open to considering the option, although it goes against the 'ruby way' adopted by most ruby projects.

bundle exec rubocop will issue warnings about conflicts with ruby conventions, it is usually simple code style, but it can also help to detect logical and design flaws. It can take a while to get familiar with the conventions, they are often helpful. The aim is to use this as a tool to provide consistent ruby code using the guidelines of the ruby community.