dpn-admin / dpn-server

Implementation of the DPN RESTful API.
Other
3 stars 6 forks source link

Build multiple databases in travis ci #118

Closed malakai97 closed 8 years ago

malakai97 commented 8 years ago

This pull request adds support for building sqlite, mysql, and postgres in travis.

Three files were created to enable this:

Additionally .travis.yml was extended to move the above files into place as well as setup the build matrix.

No changes to the ruby/rails code were involved.

dazza-codes commented 8 years ago

Some postgres errors in https://travis-ci.org/dpn-admin/dpn-server/jobs/170304591 that might be ActiveRecord bugs or might require restructuring the AR method calls?

Not sure if this is actually a blocker for this PR, because the intent of this PR is actually fulfilled by running the Postgres tests. Do we need to fix this stuff for this PR?

dazza-codes commented 8 years ago

I'm going to make a call on this and say this PR is doing what it should - it builds against all 3 db platforms intended.