search

dpnishant / appmon

Documentation:
http://dpnishant.github.io/appmon
Apache License 2.0
1.56k stars 276 forks source link

Import for scripts #37

Closed markszabo closed 6 years ago

markszabo commented 7 years ago

As asked in #36 I have implemented a proposition for import. Please have a look and let me know if you think something should be done differently.

I have tested the crypto library (SHA1 and MD5) and they work exactly as before.

PS. Sorry for the messed up end of lines. I don't know what my editor did

dpnishant commented 7 years ago

@markszabo Hey sorry for replying you so late. Could you tell on what device (and iOS version, jailbreak status) did you test the scripts? I'm not sure if the newer Duktape runtime supports the import statement? We need to confirm with @oleavr

markszabo commented 7 years ago

I've tested it on a jailbroken 4th generation iPad with iOS 8.1.2 using this simple app.

I'm not sure whether there is a need for any component to support import statements, as the code in this PR will simply concatenate every imported file to the end of the original file. If you think that the 'import utils'; statement might mess with some components, it can be removed after the concatenation or it can be changed to something else (eg. //import utils).

dpnishant commented 6 years ago

This is not needed at this time. Thanks anyways