search

dpnishant / jsprime

a javascript static security analysis tool
http://dpnishant.github.io/jsprime
Other
585 stars 103 forks source link

JS Prime Browserversion Crashing #12

Open prasanna-in opened 10 years ago

prasanna-in commented 10 years ago

Hi,

I was testing the browser version with 300 lines of JS code. after few minutes the Tab crashed.

PK

dpnishant commented 10 years ago

Please provide the JS code to reproduce.

prasanna-in commented 10 years ago

Hey

as this is production code so could be difficult sharing over a public, we would have to work a way around it.

PK

naderchehab commented 9 years ago

Here's an example of public JS code that crashes jsprime: http://www.google-analytics.com/analytics.js

Any idea why this happens? I am suspecting a memory issue or some sort of infinite recursion.

12shivaniaggarwal commented 7 years ago

Hey, even I am facing an Maximum Call Stack exceeded error on the Chrome browser in the function checkFunctionAsReturns in engine.js. Is there any workaround for this, I need to check this tool on a very large file around 1000 lines of code.

TejaswiniU commented 5 years ago

In engine.js at asignFunctionReturnValue() repetitive variable declaration made the loop run infinite times and caused heap out of memory . To overcome this loop optimisation is done by for (var j = 0; j < real_func_names.length ; j++) to var real_fun_name_length = real_func_names.length; for (var j = 0; j < real_fun_name_length ; j++) Hope this can help you

dpnishant commented 5 years ago

Hey @TejaswiniU, Would create a pull request if you have fix? I can review and merge.

TejaswiniU commented 5 years ago

I will push the code by Monday.

On Fri, Dec 28, 2018, 12:06 Nishant Das Patnaik <notifications@github.com wrote:

Hey @TejaswiniU https://github.com/TejaswiniU, Would create a pull request if you have fix? I can review and merge.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dpnishant/jsprime/issues/12#issuecomment-450300207, or mute the thread https://github.com/notifications/unsubscribe-auth/AsCvET71WNq2lvruZnV1bwlR_tFVFzcqks5u9bvZgaJpZM4Bu5Cn .

dpnishant commented 5 years ago

@TejaswiniU Thank you so much! 👍