dpoeschl / StashPop

StashPop adds features to GitHub, with extra Jenkins testing support. Get the Chrome extension at
https://chrome.google.com/webstore/detail/stashpop/nghjdgghnnljcdgaicggnlbmojcaedhl
MIT License
5 stars 9 forks source link

Don't use jQuery for registering pjax event in injectedcode.js #101

Closed akoeplinger closed 7 years ago

akoeplinger commented 7 years ago

I got the following error in console, which seemed to break the pjax detection:

injectedcode.js:1 Uncaught TypeError: $ is not a function
(anonymous function) @ injectedcode.js:1

Using jQuery isn't even necessary there as regular document.addEventListener works the same.

Fixes #100

/cc @dpoeschl

dpoeschl commented 7 years ago

Thank you! I'll publish a new version tonight!

akoeplinger commented 7 years ago

@dpoeschl ping

dpoeschl commented 7 years ago

Tested locally. LGTM.