dpoeschl / StashPop

StashPop adds features to GitHub, with extra Jenkins testing support. Get the Chrome extension at
https://chrome.google.com/webstore/detail/stashpop/nghjdgghnnljcdgaicggnlbmojcaedhl
MIT License
5 stars 9 forks source link

Feature Request: Add automated PR trigger buttons for optional jobs #48

Closed mmitche closed 8 years ago

mmitche commented 8 years ago

There are lots of optional jobs in the Jenkins config for a given repo. It would be awesome to have a way to trigger these on demand. For example, the test results could have "Test" buttons for jobs not yet run, with the job description.

dpoeschl commented 8 years ago

@mmitche The only reasonable way I can come up with to do this quickly is to have a way for users to specify these non-default test suites, and I'm considering the format:

testSuiteSpecification:     scope : suite-name     scope : suite-name : suite-name      // The first suite-name gets put in "test suite-name please" unless the second test-suite is already running/ran (see example)

scope:     organization     organization / repository

By default, I'll prepopulate this specification with

dotnet/roslyn:vsi:prtest/win/vsi/p0
dotnet/roslyn-internal:vsi:prtest/win/vsi/p0

Do you have any other suggestions for things you'd like pre-configured by default?

dpoeschl commented 8 years ago

/cc: @davkean

dpoeschl commented 8 years ago

Checked in the above proposed implementation. @mmitche If you get a chance to try it please let me know if it works for you.

mmitche commented 8 years ago

@dpoeschl That could work. I'm not sure about the specifics on the GitHub implementation, but we could also simply put a file in the root of the repo that specifies the trigger phrases that should be sent to Jenkins and the text that should be shown in the GitHub UI.

dpoeschl commented 8 years ago

@mmitche Let me make sure I understand your proposal -- The root of the repo would check in something like ".cibuilds". Any tools could then pick up on that (including non-browser-extensions), and StashPop in particular would use it to populate the list of not-yet-run test suites.

That suggestion sounds great if we can get teams to use that convention. I'd still like to keep the user-customization option available in the extension settings for automating repositories that haven't adopted such a pattern.

mmitche commented 8 years ago

@dpoeschl That would be one way to do it. It would be nice if Jenkins could inform the list, since that avoids issues with the list getting stale, but that is more difficult. Of course, having a manual list doesn't mean automatic population couldn't replace that in the future.