Support non-"dotnet" Jenkins hosts

[dpoeschl]

https://developer.chrome.com/extensions/permissions

[dpoeschl]

Need to find one to test with

[akoeplinger]

I'd volunteer https://jenkins.mono-project.com :)

[dpoeschl]

@akoeplinger Perfect - thanks!

[dpoeschl]

The current Jenkins support shows this error: "Unknown Failure - If this is a private Jenkins job, click the 'Details' button to reauthenticate and then reload this failure data." so we should distinguish between these two failure modes.

[akoeplinger]

Yes, we have an additional Xamarin-internal Jenkins, that's why it shows this for you. It works if you authenticate as the message says.

[dpoeschl]

@akoeplinger I'm confused. Are you running a custom StashPop with permissions to https://jenkins.mono-project.com in the manifest.json?

When I look at https://github.com/mono/mono/pull/2342 I see:

But when I click details on the "ARM hard float Linux" queue, I'm logged in and can see info:

But I still can't see anything on the PR page.

[dpoeschl]

As an aside, I'd like to add well-known and trusted Jenkins servers (like mono's) to the shipping manifest.json so that they work by default. All other unknown Jenkins servers would require permission be granted on first access.

[akoeplinger]

@dpoeschl yeah, I'm running a custom version. It seems to work fine for me:

Not sure why it doesn't work for Mono's public Jenkins for you?

[dpoeschl]

@akoeplinger Awesome. It's because the shipping manifest.json only allows access to the dotnet team's Jenkins server right now. I'm trying to fix that behavior for non-customized manifest.json files by 1) including more well-known jenkins servers by default and 2) allowing any jenkins server to be accessed with user-granted permissions.

[dpoeschl]

Background: Chrome extensions make you declare what domains you have access to. See https://github.com/dpoeschl/StashPop/blob/master/manifest.json#L38

I was nervous about granting access to *, but I'm okay with it as long as users have to grant access per unknown jenkins server.

[dpoeschl]

So once that work is done, you shouldn't need a customized version of StashPop anymore (unless you want to do dev)

[akoeplinger]

What about not including any Jenkins url permission by default and just requesting it on-demand on first use?

[dpoeschl]

Yep, that's another option, and I tend to like that better. As a note-to-self, I'll want to verify that the permissions roam between versions and whatnot.

[akoeplinger]

@dpoeschl I took a stab at implementing this in https://github.com/dpoeschl/StashPop/pull/70. Would love to hear your feedback :smile: