search

dpoeschl / StashPop

StashPop adds features to GitHub, with extra Jenkins testing support. Get the Chrome extension at
https://chrome.google.com/webstore/detail/stashpop/nghjdgghnnljcdgaicggnlbmojcaedhl
MIT License
5 stars 9 forks source link

Don't show "NaN days ago" #63

Closed dpoeschl closed 8 years ago

dpoeschl commented 8 years ago

image

dpoeschl commented 8 years ago

Needs repro.

dpoeschl commented 8 years ago

This may manifest differently now that we're using moment.js. If it crops up again, we can use that repro to investigate a fix. Closing for now.

akoeplinger commented 8 years ago

I still see this with moment.js, e.g. on https://github.com/mono/mono/pull/2372:

image

I looked with the debugger and timestamp in content.js:370 is "20.12.2015 11:46:14" (i.e. a localized string instead of English, afaik Jenkins uses the browser's language by default) so it can't parse it.

Did you think about using the Jenkins API instead of scraping the HTML ?

akoeplinger commented 8 years ago

I made a PR that fixes the issue: https://github.com/dpoeschl/StashPop/issues/68