search

dpoeschl / StashPop

StashPop adds features to GitHub, with extra Jenkins testing support. Get the Chrome extension at
https://chrome.google.com/webstore/detail/stashpop/nghjdgghnnljcdgaicggnlbmojcaedhl
MIT License
5 stars 9 forks source link

StashPop fails to load on PR pages with empty "Non-default test suites" options #77

Open akoeplinger opened 8 years ago

akoeplinger commented 8 years ago

One of my colleagues is getting this error in developer console and StashPop doesn't show up:

Error in event handler for (unknown): TypeError: Cannot read property 'length' of null
    at processTestFailures (chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:670:44)
    at addTestFailureButtonsAndDescriptions (chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:596:9)
    at reloadJenkins (chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:210:5)
    at chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:140:13handler @ extensions::uncaught_exception_handler:8
15chrome-extension://nghjdgghnnljcdgaicggnlbmojcaedhl/content.js:303 StashPop:  Permission present.

@dpoeschl He didn't have the extension installed before, any idea why this would happen?

dpoeschl commented 8 years ago

Investigating, but possibly useful extra info:

akoeplinger commented 8 years ago

Ok, seems like he removed the default entries from "Non-default test suites:" and other lists because he thought they don't apply to us.

dpoeschl commented 8 years ago

Wow, that's interesting. Are their options screwed up?

image

dpoeschl commented 8 years ago

Ahh, yeah, I'm not coping well with empty entries there. :frowning: Will fix up.

dpoeschl commented 8 years ago

They don't apply to you but are load bearing. :wink: