Consider adopting mq-react to manage concurrency

dpovshed / octopus

Sitemap checker/stress test tool based on ReactPHP

11 stars 1 forks source link

Consider adopting mq-react to manage concurrency #17

Closed holtkamp closed 5 years ago

holtkamp commented 6 years ago

It seems we could "outsource" the part that manages queuing in the TargetManager to https://github.com/clue/php-mq-react, this does increase the number of dependencies...

dpovshed commented 6 years ago

At a glance, the library looks nice. Not sure about 'fixing when it is not broken' :)

For me it is hard to evaluate how much lines of code we could save, without losing any functionality

holtkamp commented 5 years ago

As suggested in https://github.com/clue/reactphp-mq/issues/13#issuecomment-394108721, https://github.com/clue/reactphp-flux seems to be a better candidate for this.

Just submitted https://github.com/dpovshed/octopus/pull/31

Closing this issue