dpovshed / octopus

Sitemap checker/stress test tool based on ReactPHP
11 stars 1 forks source link

Prevent "trailing" delay caused by race promise #26

Closed holtkamp closed 6 years ago

holtkamp commented 6 years ago

In https://github.com/dpovshed/octopus/pull/12 the use of "racing" of the following promises was introduced:

It seems this approach causes an additional "wait" of timeout seconds when all URLs had been processed succesfuly (the race seems to wait until but promises are completed / does not detect completion of the URL loading...). It seems timeout() offers a more appropriate way to deal with this.