dpovshed / octopus

Sitemap checker/stress test tool based on ReactPHP
11 stars 1 forks source link

Processor::loadUrlWithBrowser() Incorrect return type used #34

Closed holtkamp closed 5 years ago

holtkamp commented 5 years ago

It is possible something else is returned:

Return value of Octopus\Processor::loadUrlWithBrowser() must be an instance of React\Promise\Promise, instance of React\Promise\RejectedPromise returned

we should probably return a PromiseInterface