dpovshed / octopus

Sitemap checker/stress test tool based on ReactPHP
11 stars 1 forks source link

PHP 8: Fatal error: Uncaught ValueError: No stream arrays were passed in vendor/react/event-loop/src/StreamSelectLoop.php:290 #45

Closed holtkamp closed 2 years ago

holtkamp commented 3 years ago

Steps to reproduce on a PHP 8 environment:

git clone https://github.com/dpovshed/octopus
cd octopus
composer install
php application.php https://www.rocktherankings.com/sitemap.xml

Note that with a "local" example, the error does not occur:

php application.php examples/sitemap-wiki.xml
holtkamp commented 3 years ago

Attempt to fix using https://github.com/dpovshed/octopus/commit/31058ecdaafe888fa0d18fa2ff689578b5828dd7, note that:

holtkamp commented 2 years ago

This was fixed after https://github.com/reactphp/filesystem/issues/89#issuecomment-873673188