dppdppd / The-Boardgame-Insert-Toolkit

This OpenSCAD library was created to make it easy to create board game inserts with lids for either horizontal or vertical storage, without any programming required.
290 stars 39 forks source link

Box is stackable by default and the BOX_STACKABLE_B is not working #45

Open fzerorubigd opened 2 years ago

fzerorubigd commented 2 years ago

This is my simple box :

z_border = 2;
z_border_twice = z_border * 2;

player_width = 90;
player_height = 75;
player_depth = 28;

data =
[
    [   "Player Box",
        [
            [ BOX_SIZE_XYZ, [player_width, player_height, player_depth] ],
            [ BOX_STACKABLE_B,false],
            [ BOX_LID,
                [
                    [ LID_SOLID_B, t],
                ]
            ],
            [ BOX_COMPONENT,
                [
                    [CMP_COMPARTMENT_SIZE_XYZ,  [ player_width - z_border_twice, player_height - z_border_twice, player_depth - z_border ] ],
                ]
            ], 
        ]
    ],
];

I am using OpenSCAD version 2021.01, with or without [ BOX_STACKABLE_B,false], the box has the edge on the button. I am using the latest git version of this toolkit.

Is there anything wrong with my data? or is it a bug, I am not sure to be honest.

fzerorubigd commented 2 years ago

I used one of the sample in the readme, it is different than the picture in readme. 2022-07-23_13-57

elgringoYan commented 2 years ago

Hi,

BOX_STACKABLE_B creates a rounded button on the bottom of the box, but also creates an inset on top of the box, so boxes can be stacked on top of another. This image was produced with your code, with BOX_STACKABLE_B = true [image: image.png]

This one with BOX_STACKABLE_B = false

[image: image.png]

You are not having the same results ?

On Sat, Jul 23, 2022 at 7:32 AM fzerorubigd @.***> wrote:

This is my simple box :

z_border = 2; z_border_twice = z_border * 2;

player_width = 90; player_height = 75; player_depth = 28;

data = [ [ "Player Box", [ [ BOX_SIZE_XYZ, [player_width, player_height, player_depth] ], [ BOX_STACKABLE_B,false], [ BOX_LID, [ [ LID_SOLID_B, t], ] ], [ BOX_COMPONENT, [ [CMP_COMPARTMENT_SIZE_XYZ, [ player_width - z_border_twice, player_height - z_border_twice, player_depth - z_border ] ], ] ], ] ], ];

I am using OpenSCAD version 2021.01, with or without [ BOX_STACKABLE_B,false], the box has the edge on the button. I am using the latest git version of this toolkit.

Is there anything wrong with my data? or is it a bug, I am not sure to be honest.

— Reply to this email directly, view it on GitHub https://github.com/dppdppd/The-Boardgame-Insert-Toolkit/issues/45, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYDTIAWFZNUC5AFYJX2AJETVVPJ5PANCNFSM54N3ZGXA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

fzerorubigd commented 2 years ago

Hi,

The image is not attached (I guess since you replayed using email) Also I opened the example.2.scad in this repository, no change at all (except adding g_isolated_print_box = "simple box"; to focus on simple box only) , and this is the result : 2022-07-23_17-55

elgringoYan commented 2 years ago

Stackable = true image

Stackable = false image

fzerorubigd commented 2 years ago

I am not sure if this is the correct behavior tho. The shot from the readme is different.

light-mooner commented 9 months ago

@fzerorubigd

You need to add [ LID_FIT_UNDER_B, f] to the LID parameters in order to have the one of the README

the point of the anchors on the bottom of the box is to fit the lid there when you keep the box opened.