dppdppd / The-Boardgame-Insert-Toolkit

This OpenSCAD library was created to make it easy to create board game inserts with lids for either horizontal or vertical storage, without any programming required.
301 stars 46 forks source link

Labels on solid lids not respecting depth? #60

Open GregRMitchell opened 1 year ago

GregRMitchell commented 1 year ago

I'm attempting to build a box for Glory to Rome, which came in an awful clamshell package. I put a label on the solid lid with the game name, and it doesn't seem to be paying any attention to the depth settings, instead being a complete void through the whole lid.

Here's my lid code:

            [ BOX_LID,
                [
                    [ LID_INSET_B, t],
                    [ LID_SOLID_B, t],
                    [ LID_HEIGHT, 4 ],
                    [ LID_SOLID_LABELS_DEPTH, 1],
                    [ LABEL, 
                        [
                            [LBL_TEXT, 
                                "Glory to Rome"
                            ],
                            [LBL_DEPTH, 1],
                            [ LBL_SIZE, AUTO],
                            [ LBL_FONT, "Times New Roman:style=bold"]
                        ]

                    ],
                ],

            ],  

Am I doing something wrong, or is it broken?

dvirbuc commented 6 months ago

I have faced the same problem, to fix it I changed the "boardgame_insert_toolkit_lib.2.scad" file a little. from (line 1745): MakeAllLidLabels( thickness = thickness );

to:

if (m_has_solid_lid && m_lid_label_depth > 0 )
    MakeAllLidLabels( thickness = thickness - m_lid_label_depth );
else
    MakeAllLidLabels( thickness = thickness );

I don't know if it breaks other stuff, but for a simple box, it's working.

file for reference: solid_lid_with_label.scad.txt boardgame_insert_toolkit_lib.2.scad.txt