dpriskorn / OpenAlexAPI

Python library for the OpenAlex HTTP API
GNU General Public License v3.0
22 stars 11 forks source link

Added new queries and new test cases #8

Closed EssentiallyNoah closed 2 years ago

EssentiallyNoah commented 2 years ago

Adds support for new queries taking advantage of the new features mentioned in #2 including:

dpriskorn commented 2 years ago

Big thanks for this PR. I really like way you implemented the cursor and paging. Thanks for the tests also :)

EssentiallyNoah commented 2 years ago

@dpriskorn is there a good way to amend authorship on the PRs? The commit username is incorrect. I've amended the branches on my fork and can re-submit the PR, but am not sure if that would cleanly overwrite a PR that has already been merged.

dpriskorn commented 2 years ago

@dpriskorn is there a good way to amend authorship on the PRs? The commit username is incorrect. I've amended the branches on my fork and can re-submit the PR, but am not sure if that would cleanly overwrite a PR that has already been merged.

I don't think so. What about we adopt the style of Guix and maintain a header in each file with copyrights with the name of all contributors? Like so: '# Copyright 2022 Dennis Priskorn, x, y

dpriskorn commented 2 years ago

I went ahead and added a header to all files. Feel free to send a PR to add your name to the files you edited.