dprojects / Woodworking

This is Woodworking workbench for FreeCAD
MIT License
212 stars 21 forks source link

If you cut a panel, it won't show up in the cut list without the base panel being shown #14

Closed akdombrowski closed 1 year ago

akdombrowski commented 1 year ago

Love the workbench! Makes my life much easier.

If you use the cut list with the visible objects option turned on so only visible objects show in the cut list, cut objects don't show up in the cut list if the base panel isn't visible.

For example, I create a panel and a dowel. If I cut the panel with the dowel, the panel and the dowel are no longer visible. I then use cut list and choose to only show visible objects, that cut object doesn't show in the cut list.

I've got a project with panels with tons of cuts, I'd have to go and make all the base panels visible in order for them to show up in the cut list. If you could show the panel dimensions if the parent cut object is visible, that'd be helpful.

Thanks!

akdombrowski commented 1 year ago

Screenshot_20230126_075611

In the image, you can see the cut object is visible but the base panel isn't. The panel (nor the cut object) won't show in the cut list.

dprojects commented 1 year ago

If you use the cut list with the visible objects option turned on

If you use Cut in the FreeCAD way you should rather use Parent + Base. More about visibility options: Docs - visibility

I guess this is the same issue as this one here: getDimensions issues 12 I believe it has been solved, and the solution is Parent + Base. However if this not work for you, provide some simple file example, single Cut, not huge project. So, I will try to figure out if there is still some scenario not covered.

dprojects commented 1 year ago

However, I see if you have many Cuts the naming conventions starts to be annoying, like "Cut, Cut, Cut... " zillion times is not good ;-) I am not sure how to approach that and fix it and keep the structure informative at the same time. This has been solved with getNestingLabel function for multiple copy, but I am not sure if this would be good approach for Cut.

akdombrowski commented 1 year ago

Ah, I didn't see that option in the cut report options. Is that in the development branch?

dprojects commented 1 year ago

Yes, this is in master branch. If you are using magicCut you should rather use visibility Off or Inherit mode. For Cut listing you can list all because all the hidden elements are cloned and the copies are turned off at report with special attribute BOM. I need to fix the "Cut,.... " labeling ;-)

dprojects commented 1 year ago

I fixed the long labeling for Cuts as well, so this should no longer be disturbing. The previous one was little more informative, especially if you already have ", " at label but there is numbering so the nesting level should also be recognized. Let me know if you have any idea for labeling. I see you use it, so maybe there is other, more comfortable way of labeling?

akdombrowski commented 1 year ago

Thanks! I'll try out the master branch. What version of FreeCad should I use?

dprojects commented 1 year ago

Thanks! I'll try out the master branch. What version of FreeCad should I use?

If you want only getDimensions macro update you can upload only the macro. If you want nesting labeling improve you have to download master branch of workbench. At 0.20 FreeCAD there is bug with Sketch create from vertices. Maybe 0.20.2 have it fixed I don't know. The weekly latest AppImage should work but I didn't test it. You can download the recommended weekly.

Regarding your problem, what is your project process? Is there any field to improve? I see you are using Cylinders for Cut. Normally, drilling feature is designed with PartDesign Hole objects not with Boolean Cut. But I saw that other people use this way too. Maybe this is worth to improve? You have sample small project to share?

akdombrowski commented 1 year ago

Thanks, things seem to be working so far on 20.2 with the master branch.

I was creating dowels using the magic dowels feature. Then, I was cutting my panels with those dowels. I want to have dowel dimensions to print out. And sometimes I have dowels going through multiple panels.

dprojects commented 1 year ago

I was creating dowels using the magic dowels feature. Then, I was cutting my panels with those dowels. I want to have dowel dimensions to print out. And sometimes I have dowels going through multiple panels.

If you cut many panels with single dowel, you can use: magicKnife. This tool creates copies for each Boolean Cut Tool element so you don't need to change default settings at getDimensions tool later. The copies will be turned off at the report and the original ones will stay in the same place and will be visible at report.

akdombrowski commented 1 year ago

It's multiple dowels positioned throughout. I stopped doing the cutting, but I uploaded it here if you want to take a look and have any suggestions: https://github.com/akdombrowski/outdoorTVStand9/blob/main/outdoorTvStand9.FCStd

dprojects commented 1 year ago

I stopped doing the cutting

I downloaded your all TVStand9 repository. My comments:

Video: https://www.youtube.com/watch?v=Oogs8LqkReQ

dprojects commented 1 year ago

Just to let you know:

Video for the features: Helping Vertex selection

Now you designing way should be much more simpler and faster. Thanks and Good Luck !

akdombrowski commented 1 year ago

This is amazing! Thank you, I will try it out.

On Thu, Feb 2, 2023 at 9:29 AM Darek L @.***> wrote:

Just to let you know:

Video for the features: Helping Vertex selection https://www.youtube.com/watch?v=qSsua04AKg8

Now you designing way should be much more simpler and faster. Thanks and Good Luck !

— Reply to this email directly, view it on GitHub https://github.com/dprojects/Woodworking/issues/14#issuecomment-1413927235, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADR4RRJ2IOKL3PE5SESZB4DWVPHE7ANCNFSM6AAAAAAUIFRFEU . You are receiving this because you modified the open/close state.Message ID: @.***>