dprojects / Woodworking

This is Woodworking workbench for FreeCAD
MIT License
200 stars 17 forks source link

magicManager error or abuse? #22

Closed ansgar02 closed 7 months ago

ansgar02 commented 1 year ago

I'm trying to use the MagicManager to create a panel between two panels (beams) (named "QT Oben Hinten" and "QT Oben Vorne" in container "QT Oben" with respective faces "Face5" and "Face6" (see attached FCStd file). When I do so, the Report View shows the following lines: 22:12:14 Traceback (most recent call last): 22:12:14 File "C:\Users\Ansgar\AppData\Roaming\FreeCAD\Mod\Woodworking.\Tools\MagicPanels\magicManager.py", line 739, in setMode 22:12:14 self.setNextPanel() 22:12:14 File "C:\Users\Ansgar\AppData\Roaming\FreeCAD\Mod\Woodworking.\Tools\MagicPanels\magicManager.py", line 821, in setNextPanel 22:12:14 self.previewPanel() 22:12:14 File "C:\Users\Ansgar\AppData\Roaming\FreeCAD\Mod\Woodworking.\Tools\MagicPanels\magicManager.py", line 672, in previewPanel 22:12:14 self.projectPanelBetween(self.gPanelArr[self.gPanelIndex]) 22:12:14 File "C:\Users\Ansgar\AppData\Roaming\FreeCAD\Mod\Woodworking.\Tools\MagicPanels\magicManager.py", line 607, in projectPanelBetween 22:12:14 if L <= 0 or W <= 0 or H <= 0: 22:12:14 TypeError: '<=' not supported between instances of 'str' and 'int'

my environment: [code] OS: Windows 10 Version 2009 Word size of FreeCAD: 64-bit Version: 0.21.0.32552 (Git) Build type: Release Branch: master Hash: e2b3a5d2f791fb78a61daac9bdab374058f682f2 Python 3.8.10, Qt 5.15.2, Coin 4.0.1, Vtk 8.2.0, OCC 7.6.3 Locale: German/Germany (de_DE) Installed mods:

my debugInfo shows a half green/red bug with "Tests failed: qApp" Which FC version should be used with this version of the WB?

Am I using this feature the wrong way?

In the attachement please find my FCstd file and the screen shot with the report view .

Cheers Oerly.

Screenshot 2023-04-19 222828 WB004.01FCStd.FCStd.zip

dprojects commented 1 year ago

I'm trying to use the MagicManager to create a panel between two panels (beams) (named "QT Oben Hinten" and "QT Oben Vorne" in container "QT Oben" with respective faces "Face5" and "Face6" (see attached FCStd file).

This is caused because those panels are rotated. If you want to rotate elements put them into container and rotate container instead of rotating the element. The workbench is not ready for single elements rotation, this is mostly caused by problem with determining the plane if the element is rotated.

my debugInfo shows a half green/red bug with "Tests failed: qApp" Which FC version should be used with this version of the WB?

The FreeCAD 0.20 stable version has qApp defined but the 0.20 workbench not has so much features.
Currently there is no FreeCAD version with defined qApp, see more: https://forum.freecad.org/viewtopic.php?p=676143#p676143 I am waiting for FreeCAD 0.21 and will decide if he qApp test make sense.

I will keep the issue open because maybe I will look into rotation problem more deeply finally.

ansgar02 commented 1 year ago

Thank you for your swift response - and well - I remember having read about this advice but actually following it sometimes needs another round... Placing those in containers made the magicPanels work as expected. Many thanks again!

Not sure I understood your FC version recommendation. As I am on MS-W10 (knowing your base is Linux) should I better use the official FC 020 version or the 0.21 version (which I was using when encountering the above issue)?

Ansgar

dprojects commented 1 year ago

Hello, I made small rotation improvements. Now the direct object rotation is better supported. You can create panel at face for rotated object. You can also create router edge at rotated objects.

However, creation panel between rotated objects is still not covered. This require more advance calculation in relation to the anchor. I am not sure if this will be covered but the rotation improvements will be continued.

ansgar02 commented 1 year ago

Hello,

many thanks for addressing this – and for the notification.

I will look into it in the following days.

Cheers

Ansgar

From: Darek L @.*** Sent: Montag, 8. Mai 2023 20:42 To: dprojects/Woodworking Cc: ansgar02; Author Subject: Re: [dprojects/Woodworking] magicManager error or abuse? (Issue #22)

Hello, I made small rotation improvements https://github.com/dprojects/Woodworking/commit/fa1dbc8177cb83fc44d174e0dff6187120092995 . Now the direct object rotation is better supported. You can create panel at face for rotated object.

However, creation panel between rotated objects is still not covered. This require more advance calculation in relation to the anchor. I am not sure if this will be covered but the rotation improvements will be continued.

— Reply to this email directly, view it on GitHub https://github.com/dprojects/Woodworking/issues/22#issuecomment-1538858718 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEOCVOVTMMTN3ELGSSELKLXFE46DANCNFSM6AAAAAAXESSWO4 . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ALEOCVMZAXJMJTALN7IDZMLXFE46DA5CNFSM6AAAAAAXESSWO6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS3XEPN4.gif Message ID: @.***>

dprojects commented 1 year ago

I will keep this issue open until the rotation feature will be fully finished. At the end I will try to find out the way to support also the panel between rotated objects. Now if you want to create panel between rotated objects without containers you should rather use panel from vertices option.

dprojects commented 7 months ago

Hello again, I was looking at this problem again, and I am not sure for adding additional option to magicManager. Generally panels should be rotated via LinkGroup container, but if you have single rotated panel and you really don't want to use containers you can always use panel from vertices. At your example there is not need to rotate panel at all.

I am not sure it is worth to keep this issue open? Feel free to re-open this issue if you have questions. Thanks !

ansgar02 commented 7 months ago

Hi Darek

Thank you very much for looking into this – again.

Thank you very much – also for creating this great tool at all!

Best regards,

Ansgar

From: Darek L @.*** Sent: Sonntag, 4. Februar 2024 22:13 To: dprojects/Woodworking Cc: ansgar02; Author Subject: Re: [dprojects/Woodworking] magicManager error or abuse? (Issue #22)

Hello again, I was looking at this problem again, and I am not sure for adding additional option to magicManager. Generally panels should be rotated via LinkGroup container, but if you have single rotated panel and you really don't want to use containers you can always use panel from vertices. At your example there is not need to rotate panel at all.

I am not sure it is worth to keep this issue open? Feel free to re-open this issue if you have questions. Thanks !

— Reply to this email directly, view it on GitHub https://github.com/dprojects/Woodworking/issues/22#issuecomment-1925915830 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEOCVK4VYVT33F7DF3432DYR72V3AVCNFSM6AAAAAAXESSWO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRVHEYTKOBTGA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ALEOCVOZ4GYZZM2KMT3CH4LYR72V3A5CNFSM6AAAAAAXESSWO6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTSZMSLM.gif Message ID: @.***>