dprojects / Woodworking

This is Woodworking workbench for FreeCAD
MIT License
200 stars 17 forks source link

toCut uses template already used by TechDraw causing serious issue, when the toPrint is deleted #25

Closed przemhb closed 1 year ago

przemhb commented 1 year ago

In my project I have a few technical drawings created in the TechDraw. I have noticed, that when I run Woodworking's getDimensions function then the resulting toPrint uses the same template as the first TechDraw drawing. As a result, when I delete the toPrint with "its" template, then the template gets removed from the TechDraw page. It causes serious issue. Missing template cannot be added, project has error, cannot be recomputed and properties are no longer displayed. Furthermore the TechDraw cannot be even deleted to start from scratch. Recovering from the issue is really hard.

image

przemhb commented 1 year ago

FreeCad 0.20.2, Woodworking 0.20.

dprojects commented 1 year ago

Hi, can you attach file sample? No real-life project, just sample to reproduce the problem, I will look into that later what is going on there.

przemhb commented 1 year ago

Here you have it:

template-issue.zip

Run getDimensions with default settings and then delete template from the "toPrint" and notice it gets deleted from the "01.01'A Blat" technical drawing. Apparently "toPrint" links to already existing template instead of creating a new one.

dprojects commented 1 year ago

Has been fixed by: fix template overwrite . Thanks.