Rename differential types

dpsanders / ReversePropagation.jl

MIT License

52 stars 6 forks source link

Rename differential types #38

Closed mzgubic closed 3 years ago

mzgubic commented 3 years ago

We deprecated the old names in ChainRulesCore: https://github.com/JuliaDiff/ChainRulesCore.jl/pull/353

But I suspect that the @reexport macro does not reexport the deprecated names, so since ReversePropagation only depends on ChainRules it breaks. We are thinking about whether we should change that (https://github.com/JuliaDiff/ChainRules.jl/issues/415)

Anyway, here's the fix

oxinabox commented 3 years ago

may want to add ChainRulesCore as a direct dependency so that can lower bound it easily to the version that has the new names

dpsanders commented 3 years ago

That's great, thanks a lot!