search

dpup / git-workflow

Opinionated tools for managing a team based git workflow
Apache License 2.0
91 stars 16 forks source link

Optionally alias/blacklist reviewers when making PRs #12

Closed maiamcc closed 5 years ago

maiamcc commented 5 years ago

Addresses two problems:

  1. I don't want to have to remember teammate's git handles when asking them to review my PRs (now I can alias them and just tag in teammates by their first name)
  2. I keep assigning PRs to the wrong folks (e.g. poor dmiller, who I keep tagging because dmiller is a teammate's handle on slack but NOT on github)
dpup commented 5 years ago

Looks like you figured it out! Nice work. The change seems good to me. Is it ready to go then?

maiamcc commented 5 years ago

Yep, it should be!

maiamcc commented 5 years ago

Ready for review at your convenience :)

dpup commented 5 years ago

Thanks for the patch. Any interest in sending a followup to update the README with instructions on how to use these new features?

maiamcc commented 5 years ago

Yes, will do!

...though I sat down to try and write the README entry and... honestly can't think of a reason why you'd blacklist someone instead of just aliasing their handle to the one you meant to write. Unless you're attached to that feature (i.e. blacklisting as opposed to aliasing), I'll just take it out 😅

dpup commented 5 years ago

Perhaps there's a service account you don't want to send reviews to accidentally, but without autocomplete I agree that it's possibly not super useful.