search

dpwe / audfprint

Landmark-based audio fingerprinting
MIT License
547 stars 123 forks source link

Couldn't match the query.mp3 #46

Open wadesunyang opened 5 years ago

wadesunyang commented 5 years ago

thanks for your code.

but I couldn't match the query.mp3 in tests/data/query.mp3

I test as follows: python3 audfprint.py new --dbase fpdbase.pklz tests/data/Nine_Lives/0.mp3 python3 audfprint.py add --dbase fpdbase.pklz tests/data/Nine_Lives/1.mp3 python3 audfprint.py match --dbase fpdbase.pklz tests/data/query.mp3

Then get the result: NOMATCH tests/data/query.mp3 5.6 sec 267 raw hashes

so i didn't know why the result is not same as in README? Thank you very much, wish to your replay.

dpwe commented 5 years ago

I had difficulty getting the code to run under Python3; specifically, I couldn't get librosa to install under python 3.7 MacOS mojave. But when I replaced librosa.stft with a equivalent replacement (which was all I was using), it worked.

The databases written by py2.7 were not readable with py3, but recreating everything under py3 worked.

How did you get it working under py3?

DAn.

On Thu, Nov 22, 2018 at 7:17 AM wadesunyang notifications@github.com wrote:

thanks for your code.

but I couldn't match the query.mp3 in tests/data/query.mp3

I test as follows: python3 audfprint.py new --dbase fpdbase.pklz tests/data/Nine_Lives/0.mp3 python3 audfprint.py add --dbase fpdbase.pklz tests/data/Nine_Lives/1.mp3 python3 audfprint.py match --dbase fpdbase.pklz tests/data/query.mp3

Then get the result: NOMATCH tests/data/query.mp3 5.6 sec 267 raw hashes

so i didn't know why the result is not same as in README? Thank you very much, wish to your replay.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dpwe/audfprint/issues/46, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhs0dcnxtfJXroawYHxcS-ZfmXQqFYIks5uxpXJgaJpZM4YvPT6 .

wadesunyang commented 5 years ago

thanks for your reply.

I used the pip3 to install all the lib in requirements.txt, and then it can worked in python3 （linux 16.04）.

and then i will try to install it under python 2.7 , and see if it has the different result. thank you

dpwe commented 5 years ago

I just pushed a bunch of changes to fix Python 3.7 compatibility; I'm hoping this will fix your issues.

wadesunyang commented 5 years ago

couldn't match the query.mp3 with py2.7, but i could match the 01-Nine_Lives.mp3, haha, maybe something wrong with query.mp3 or due to the parameter， i will read the code and try to test other songs.
sorry for my poor english~

jmmcd commented 5 years ago

Just an extra datapoint: on Mojave, with Py3.7 and requirements.txt items all installed using Anaconda, it works out-of-the-box. Only thing to note is that librosa is not mentioned in requirements.txt. I installed it with pip.

dpwe commented 5 years ago

Sounds good. I actually attempted to remove the dependency on librosa by adding stft.py; it's still referenced in the display stuff, but I assume most people don't use that.

DAn.

On Tue, Mar 26, 2019 at 9:18 AM James McDermott notifications@github.com wrote:

Just an extra datapoint: on Mojave, with Py3.7 and requirements.txt items all installed using Anaconda, it works out-of-the-box. Only thing to note is that librosa is not mentioned in requirements.txt. I installed it with pip.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dpwe/audfprint/issues/46#issuecomment-476627704, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhs0RjvYd2aW-V-w2vsApwJKBwSRsmoks5vah4FgaJpZM4YvPT6 .