search

dqgorelick / tabbo

Browser tab management extension
MIT License
8 stars 1 forks source link

Update build process #29

Closed jwoos closed 4 years ago

jwoos commented 5 years ago
  1. Fixed TypeScript not loading the webextension-polyfill-ts by changing module resolution method to be Node
  2. Webpack now shows all built modules - the default was to hide some. It's much easier to debug now.
  3. Webpack also logs information from ts-loader now. Better for debugging.
  4. Cleaned up tsc options and specified files to run it on. When run with --noEmit it's a type checking tool. a. Support for modules seems pretty good though so we might want to even ditch bundlers: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import
  5. Added Parcel as a new option. It's zero configuration but it does not show any errors on build. However, we can just run tsc as a type checker prior to building! scripts/build-new.sh is the new script. Left the old one for now.

Resolves #28

jwoos commented 4 years ago

@dqgorelick can you take a look when you get the chance?

dqgorelick commented 4 years ago

The "instructions" and "keybinds" buttons aren't doing anything for me in firefox.

dqgorelick commented 4 years ago

They also aren't working for me in Chrome :/

jwoos commented 4 years ago

Will take a look

jwoos commented 4 years ago

@dqgorelick fixed branch - tested on both ff and chrome