dqrobotics / python

The DQ Robotics library in Python
https://dqrobotics.github.io
GNU Lesser General Public License v3.0
24 stars 9 forks source link

[BUG] The `DQ_Kinematics::line_to_line_residual` is not correctly exposed to Python. #48

Closed qlin960618 closed 1 year ago

qlin960618 commented 1 year ago

Code of Conduct

By submitting this report you automatically agree that you've read and accepted the following conditions.

~Bug description~ ~line_to_line_residual is the DQ_Kinematic was not pesent. Comment seem to reference to line_to_point_residual instead.~

~propose fix maybe in #47~

Edit by @mmmarinho for clarity:

Bug

There is no line_to_line_residual accessible through the Python API.

Cause

There are two wrappers for line_to_point_residual one in L62 and one in L64. Probably it was a typo, and given that pybind11 doesn't complain about redefined wrappers (at least not in this situation), it has been around for a long time.

https://github.com/dqrobotics/python/blob/413595ee8c1964a7b960c687c19e4f9603d17c35/src/robot_modeling/DQ_Kinematics_py.cpp#L62

https://github.com/dqrobotics/python/blob/413595ee8c1964a7b960c687c19e4f9603d17c35/src/robot_modeling/DQ_Kinematics_py.cpp#L64

Fix

See #47

mmmarinho commented 1 year ago

@qlin960618 Thanks, if the CI passes you can check the new ‘—pre’ version and it should be working.