dr-itz / RedminePlannerPlugin

Resource planning plugin for Redmine 2.x/3.x - UNMAINTAINED
Other
42 stars 22 forks source link

Planner setting tab doesn't appear in the Project setting page #22

Closed dshlai closed 9 years ago

dshlai commented 10 years ago

Hi! Thanks for the plugin. It was very useful for us.

However, I currently have a issue where the Setting tab doesn't appear in the Project setting page.

Is there any known plugin conflict with Planner?

I am using latest (2.5.1) Bitnami Redmine instance on AWS:

Environment:
  Redmine version                2.5.1.stable
  Ruby version                   1.9.3-p545 (2014-02-24) [x86_64-linux]
  Rails version                  3.2.17
  Environment                    production
  Database adapter               Mysql2
SCM:
  Subversion                     1.8.8
  Mercurial                      2.1
  Cvs                            1.12.13
  Git                            1.9.0
  Filesystem                     
Redmine plugins:
  csv_import_users               1.0.0
  planner                        0.4
  redmine_agile                  1.3.1
  redmine_banner                 0.0.9
  redmine_bootstrap_kit          0.1
  redmine_contacts               3.2.17
  redmine_dashboard              2.2.2
  redmine_impersonate_plugin     0.0.1
  redmine_issue_favicon          0.0.1
  redmine_issue_templates        0.0.8
  redmine_issues_sidebar_time_entries_links 0.0.1
  redmine_knowledgebase          3.0.4
  redmine_people                 0.1.8
  redmine_planning               0.7.6
  redmine_pusher_notifications   1.0.1
  redmine_spent_time             2.6.5
  redmine_theme_changer          0.1.1
  redmine_zenedit                0.0.2
  timelog_on_issue_page          0.0.1
dr-itz commented 10 years ago

Hi There's no known incompatiblity, but then again you've got quite a list of plugins. What might be the problem is the permissions: Make sure the module is enabled in your project and your user role has the Planner permissions set (Administration -> Roles and permissions -> "Manager" -> Planner -> "Administer Resource Plan ")

dr-itz commented 10 years ago

Any more information for this?

acki commented 9 years ago

I have the same problem. It is a conflict with redmine_contacts. Maybe you can fix it?

alterdaemon commented 9 years ago

I confirm the problem (I am also using redmine_contacts) - no settings tab.

dr-itz commented 9 years ago

Yes, confirmed. The bug is clearly in redmine_contacts. It breaks other plugins as well. Every plugin that is loaded before redmine_contacts possibly breaks, every plugin that is loaded after redmine_contacts is unaffected. This fixes it:

--- plugins/redmine_contacts/lib/redmine_contacts/patches/projects_helper_patch.rb.old  2014-11-07 13:58:51.000000000 +0100
+++ plugins/redmine_contacts/lib/redmine_contacts/patches/projects_helper_patch.rb  2014-11-07 13:02:52.000000000 +0100
@@ -38,12 +38,12 @@
         def project_settings_tabs_with_contacts
           tabs = project_settings_tabs_without_contacts

-          tabs.push({ :name => 'contacts',
+          tab = { :name => 'contacts',
             :action => :manage_contacts,
             :partial => 'projects/contacts_settings',
-            :label => :label_contact_plural })
-          tabs.select {|tab| User.current.allowed_to?(tab[:action], @project)}
-
+            :label => :label_contact_plural }
+          tabs << tab if User.current.allowed_to?(tab, @project)
+          tabs
         end

       end

Please report it to the authors along with the patch.

acki commented 9 years ago

Thx!

alterdaemon commented 9 years ago

I have sent it to RedmineCRM team, they're going to patch it.

kirbez commented 9 years ago

Thank you for solution. We will implement it in next release