dr-leo / pandaSDMX

Python interface to SDMX
Apache License 2.0
129 stars 60 forks source link

make AnyUrl type available again #244

Open Ratgor opened 1 year ago

Ratgor commented 1 year ago

I had to patch the last versions of pandasdmx in a project
because I need to support extra url formats validation
(urls without top-level domain or http/https schema)

As I noticed AnyUrl had been used instead of HttpUrl in earlier versions.

e.g. for the latest v1.10 in the file site-packages/pandasdmx/source/__init__.py line 0: from pydantic import HttpUrl -> from pydantic import HttpUrl, AnyUrl # PATCH: AnyUrl added to support extra url formats line 33: url: Optional[HttpUrl] -> url: Optional[AnyUrl] # PATCH: AnyUrl forced instead of HttpUrl to support extra url formats

Q1: will the AnyUrl be back again? (by default or as an option) Q2: should I make a PR here with my changes?