search

dr0pdb / My-Companion

:computer: :notebook_with_decorative_cover: Android app that caters to the need of an undergraduate student
17 stars 37 forks source link

Use Retrofit instead of Volley to make Network requests #23

Closed dr0pdb closed 5 years ago

dr0pdb commented 6 years ago

Volley isn't an industry standard now, So i think we should move to using Retrofit to make Network requests.

eXeeLD commented 6 years ago

Hi , can i start working on this issue ?

dr0pdb commented 6 years ago

Yes, please go ahead.

eXeeLD commented 6 years ago

i opened a PR, thank you

eXeeLD commented 6 years ago

@srv-twry i redone my pull request, can you please check them

dr0pdb commented 6 years ago

@eXeeLD Yes i will check them when i get time :smile: It seems that you don't know how to automatically link an issue with a PR. This would be a good read.

eXeeLD commented 6 years ago

@srv-twry thank you a lot , i'm new to the contribution to open source stuff, i don't know a lot of things yet

smoralb commented 5 years ago

Hi! I would like to know if this issue is closed or it is still open. I would like to contribute in this project and I know how to work with Retrofit 2. I don't know if @eXeeLD would like to work together.

Thanks!

dr0pdb commented 5 years ago

Hi @smoralb this issue is done. I will merge the work done by @eXeeLD . Please find other issues to work on :)