search

dr3ams / Life-in-the-village-3

Life in the village 3 Minecraft modpack
https://www.curseforge.com/minecraft/modpacks/life-in-the-village-3
Other
5 stars 2 forks source link

[Bug]: linux run.sh is not meaningfully a shell script #48

Open seebs opened 1 year ago

seebs commented 1 year ago

General Info

Your launcher

N/A, server side

Modpack version

serverpack 1.10

Describe your issue

run.sh script isn't a valid script

Steps to reproduce the issue

sh run.sh

Additional Information

The issue is that @filename is a DOS batch file thing, if you do this in shell scripts, you just get an error that @user_jvm_args.txt is not a recognized option.

Maybe try:

java $(<user_jvm_args.txt) $(<libraries/net/minecraftforge/forge/1.18.2-40.2.0/unix_args.txt) "$@"

which should work for bash. You might also want to change the first line to invoke bash, not sh, because there's Linuxes where plain sh won't support that.

NutchapolSal commented 4 months ago

actually, @filename is a java thing, not shell functionality see this javadoc

Gunner76th commented 4 months ago

General Info

  • [ ] I didn't added any mods
  • [ ] I can reproduce this issue consistently in single-player
  • [ ] I can reproduce this issue consistently in multi-player
  • [x] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
  • [ ] I am crashing and can provide my crash report(s)
  • [x] I am using the latest version of the modpack

Your launcher

N/A, server side

Modpack version

serverpack 1.10

Describe your issue

run.sh script isn't a valid script

Steps to reproduce the issue

sh run.sh

Additional Information

The issue is that @filename is a DOS batch file thing, if you do this in shell scripts, you just get an error that @user_jvm_args.txt is not a recognized option.

Maybe try:

java $(<user_jvm_args.txt) $(<libraries/net/minecraftforge/forge/1.18.2-40.2.0/unix_args.txt) "$@"

which should work for bash. You might also want to change the first line to invoke bash, not sh, because there's Linuxes where plain sh won't support that.

The run.bat and run.sh files are automatically created by the Forge installer and is not something we create. This is an issue you would need to take up with Forge not modpack developers.

image This is from a fresh install using the Forge 1.19.2 43.3.0 installer. As you can see, they are using the @ method.