dr3ams / Life-in-the-village-3

Life in the village 3 Minecraft modpack
https://www.curseforge.com/minecraft/modpacks/life-in-the-village-3
Other
5 stars 2 forks source link

[Bug]: Disabling Blossom trees in worldgen removes recipes #81

Closed Linguardium closed 11 months ago

Linguardium commented 11 months ago

General Info

Your launcher

PrismLauncher

Modpack version

2/2

Describe your issue

Title.

If generation of blossom trees is disabled in quark config https://github.com/dr3ams/Life-in-the-village-3/blob/1b7a71087473eea126bb37914a058db992029a70/config/quark-common.toml#L787 then the recipes for the blossom trees are removed by quark.

This creates an issue where Blossom logs, planks, etc do not show up in JEI, and planks cannot be crafted without some Create-ive mod usage.

Steps to reproduce the issue

open world look for Blossom things in jei

/give blossom logs and saplings to player since they do not show up verify you cannot make planks in a crafting table

Additional Information

I tried "fixing" this by setting a blacklist of "minecraft:is_overworld" for the spawn biome tags and enabling blossom worldgen. This seems to resolve the issue but may cause problems if any mod adds biomes to the overworld and not to the is_overworld biome tag (easily fixed by either adding them to the tag via kubejs or adding them to the blacklist biome list.

dr3ams commented 11 months ago

Re-enabled with reduced rarity