dr3ams / Roguelike-Adventures-and-Dungeons-2

Roguelike Adventures and Dungeons 2
https://www.curseforge.com/minecraft/modpacks/roguelike-adventures-and-dungeons-2
Other
57 stars 17 forks source link

[Bug]: Combining STACKED enchanted books... creates an error item? #337

Closed MommaDragon closed 1 year ago

MommaDragon commented 1 year ago

General Info

Your launcher

CurseForge

Modpack version (Do not say latest check curseforge has it on modpacks icon)

1.6

Describe your issue

Check "additional information" for the screenshot showing exactly what is going on.

The book enchantments don't matter; it just has to involve stacked books (why can you stack enchantments?)... and the FIRST item has to be stacked.

This is not a crash - it's entirely item-based. Probably just a bug because of enchantments being allowed to stack, though... probably just how the game can't handle things too well and KubeJS having to "step in."

Steps to reproduce the issue

  1. Make your anvil and books (that you probably found)
  2. Attempt to put a stack in the first slot and any amount of books in the second slot
  3. KubeJS complains.
  4. Do the same, but 1 book to (at least) 2 books.
  5. The extra book is strangely missing, resulting in... otherwise normal enchanted book.

Additional Information

image

Stack of 2 being added to 1.

image

Stack of 1 being added to 2. Two stack is level 2 enchantment, resulting in... level 2 enchantment.

It's extremely niche.

latest.log

Latest.log, if (really) necessary.

DoctorMage commented 1 year ago

This is intended to prevent dupes/ deleting books

vanilla only supports 1 book

books stacking is a qol of life feature added to the modpack

DoctorMage commented 1 year ago

my bad bottom image should not be possible

only one book can be applied at a time this will be fixed next update

anymore can void excess books or lead to dupe

Zarchyar commented 1 year ago

Updated script to "fix" this for the next update