dr3ams / Roguelike-Adventures-and-Dungeons-2

Roguelike Adventures and Dungeons 2
https://www.curseforge.com/minecraft/modpacks/roguelike-adventures-and-dungeons-2
Other
54 stars 17 forks source link

[Bug]: Memory Leak From Mining Too Fast #355

Open ForgottenAngel opened 10 months ago

ForgottenAngel commented 10 months ago

General Info

Your launcher

PrismLauncher

Modpack version (Do not say latest check curseforge has it on modpacks icon)

1.7

Describe your issue

While mining in the Nether, memory usage will climb before finally being booted back to the menu screen with a message saying that Minecraft has run out of memory. The heap memory remains the same while the memory usage shown within Task Manager climbs. The error occurs after less than 5 minutes of mining.

If I mine slowly (i.e. blocks are not insta-breaking), the memory usage will climb with every block broken and every item dropped from mining but memory usage would then decrease after picking up the blocks that were left on the ground. Further testing using a Magnetic Ring and Magnet Upgrade on my backpack to ensure items are being picked up yielded the same result.

However, while mining with a pickaxe that could instantly break stone and netherrack, regardless of if items are being picked up, the memory usage will not decrease. Mining with an insta-break pickaxe would eventually lead to Minecraft consuming increasing amounts of memory before being kicked back to the menu screen with the error, "Minecraft has run out of memory." I suspect there is a memory leak occuring stemming from code that is executed when a block is broken.

Steps to reproduce the issue

  1. Equip any pickaxe that can instantly mine blocks, in this example one that can instantly mine netherrack and stone will be used.
  2. Start rapidly mining either netherrack or stone.

Result: Minecraft will start consuming more and more memory with each block mined and picking up the blocks will not bring the memory usage back down.

Additional Information

latest.log

DoctorMage commented 10 months ago

define instant mine via enchants or just any?

Will test

DoctorMage commented 10 months ago

image unbreaking 3 efficiency 5 netherite pickaxe with haste 2 image

DoctorMage commented 10 months ago

well this is a clue from logs

[12Nov2023 02:10:10.686] [Render thread/ERROR] [net.minecraft.client.multiplayer.PlayerController/]: Too many unacked block actions, dropping (Mutable{x=90, y=111, z=-36}, START_DESTROY_BLOCK) [12Nov2023 02:10:10.812] [Render thread/ERROR] [net.minecraft.client.multiplayer.PlayerController/]: Too many unacked block actions, dropping (Mutable{x=90, y=110, z=-36}, START_DESTROY_BLOCK) [12Nov2023 02:10:10.812] [Render thread/ERROR] [net.minecraft.client.multiplayer.PlayerController/]: Too many unacked block actions, dropping (Mutable{x=89, y=110, z=-36}, START_DESTROY_BLOCK)

DoctorMage commented 10 months ago

how much ram do you have allocated to the modpack

ForgottenAngel commented 9 months ago

Hi, apologies for the late response. I tested only instant mine via Enchants. I tested this with both 6GB and 8GB of RAM allocated to the modpack.

DoctorMage commented 9 months ago

This only occurs on the server or in singleplayer as well does it occur to other players?

ForgottenAngel commented 9 months ago

It doesn't occur in singleplayer only on server. It occurs to every player on the server. I don't know if the information is useful but the server host being used is Bisect.