dr460nf1r3 / firedragon-browser

A Floorp fork with custom branding and opinionated settings 🐉 (mirrored from GitLab)
https://firedragon.garudalinux.org
Mozilla Public License 2.0
272 stars 15 forks source link

Dark Reader breaks and Addons website doesn't see my browser after disabling ResistFingerprinting #31

Open badlydrawnface opened 2 years ago

badlydrawnface commented 2 years ago

Operating System: Garuda Linux FireDragon (and LibreWolf) Version: 100.0

When I disable ResistFingerprinting in a new profile, Dark Reader is stuck loading, and i get this error running FireDragon in a terminal when I try opening Dark Reader: Extension error: TypeError: (destructured parameter) is undefined moz-extension://46aac3b1-3fe1-4ee3-bb4d-905050a2883e/ui/popup/index.js 1258 [[Exception stack sendRequest/</<@moz-extension://46aac3b1-3fe1-4ee3-bb4d-905050a2883e/ui/popup/index.js:1258:60 Current stack applySafeWithoutClone@resource://gre/modules/ExtensionCommon.jsm:698:13 wrapPromise/<@resource://gre/modules/ExtensionCommon.jsm:878:22 ]]

In addition, the Addons Store doesn't see me using Firefox, prompting me to download it, when ResistFingerprinting is disabled.

Dark Reader then works upon enabling it again, as well as the addons store working properly.

In a pre-existing profile, I can't get Dark Reader to work again after enabling ResistFingerprinting.

I get this running the profile in a terminal upon opening Dark Reader: [[Exception stack sendRequest/</<@moz-extension://9e522971-a340-439b-a28f-43ae6b2f3d48/ui/popup/index.js:1258:60 Current stack applySafeWithoutClone@resource://gre/modules/ExtensionCommon.jsm:698:13 wrapPromise/<@resource://gre/modules/ExtensionCommon.jsm:878:22 ]]

I have tested both issues in LibreWolf, and these aren't issues there. librewolf-2022-05-13_12 58 12

dr460nf1r3 commented 2 years ago

Could you install the latest version of FireDragon from Chaotic-AUR and report back if its still an issue? The PKGBUILD is now really close to Librewolf to not introduce additional issues like this. I wasn't able to reproduce it following your instructions on the latest version :)

badlydrawnface commented 2 years ago

It works now, thank you!

dr460nf1r3 commented 2 years ago

Glad to hear this! Cheers :)

JosephReza commented 2 years ago

Hello,

I receive this issue still even when installing from the Chaotic AUR. I get the same error:

ATTENTION: default value of option mesa_glthread overridden by environment. Extension error: TypeError: (destructured parameter) is undefined moz-extension://6314f4e2-7d41-4b22-80c9-4b085e88f2f4/ui/popup/index.js 1259 [[Exception stack sendRequest/</<@moz-extension://6314f4e2-7d41-4b22-80c9-4b085e88f2f4/ui/popup/index.js:1259:60 Current stack applySafeWithoutClone@resource://gre/modules/ExtensionCommon.jsm:710:13 wrapPromise/<@resource://gre/modules/ExtensionCommon.jsm:890:22 ]]

I tried updating, reinstalling, deleting the .firedragon directory in my home folder, etc. and nothing worked.

Technetium1 commented 2 years ago

@dr460nf1r3 I have no power to reopen :P

TheEssem commented 2 years ago

Seems to be related to the chrome.runtime.sendMessage call in Connector#sendRequest; the callback is returning a null value when resistFingerprinting is disabled, which is interesting since it seems like the type of thing that would happen when it's enabled instead.