dr460nf1r3 / firedragon-browser

A Floorp fork with custom branding 🐉 (mirrored from GitLab)
https://forum.garudalinux.org/t/5018
Mozilla Public License 2.0
244 stars 12 forks source link

Unable to install unsigned extensions #55

Closed stefanwimmer128 closed 5 months ago

stefanwimmer128 commented 1 year ago

Even after setting "xpinstall.signatures.required" to "false" in "about:config" I was not able to install an unsigned extension, which I used previously on LibreWolf using the same setting.

dr460nf1r3 commented 1 year ago

Hey :) this is caused by line, which I already contemplated removing in the past.

stefanwimmer128 commented 1 year ago

Thanks. I changed the line and compiled it myself. Now it works.

export MOZ_REQUIRE_SIGNING=

Interestingly removing the line didn't work, apparently it defaults to 1. And 0 is not a valid value.

EDIT: For all interested: AUR-Package available here and CI-Builds available here.

stefanwimmer128 commented 1 year ago

FYI, since this is a security relevant change, I would not mind maintaining my own fork. I would not want to risk opening this potential security hole in a browser that is installed by default on all computers running Garuda Linux.

Technetium1 commented 1 year ago

@stefanwimmer128 is that really the only way? https://bugs.gentoo.org/802285#c1 https://bugs.archlinux.org/task/63075

stefanwimmer128 commented 1 year ago

@Technetium1 Not sure, ultimately it's up to the maintainer to decide whether it's safe to remove the extension signing requirement. I'm just offering to maintain my own fork - which I'm already doing to make manually building it easier (AUR, CI-Builds) -, in case it is not feasible to change it for all users.

Technetium1 commented 1 year ago

Looks like the flag can be altered such that you can install unsigned extensions into the install dir though?

stefanwimmer128 commented 1 year ago

Firedragon already includes the flag --with-unsigned-addon-scopes=app,system and it does work, but it only allows installing unsigned extensions by manually putting them in /usr/lib64/firefox/browser/extensions. What I need is to be able to install them for a single profile in about:addons using the Install Add-on From File...-Option. For that I only found the solution provided by dr460nf1r3.

But I realize this is a very specific use case, which is why I really wouldn't mind maintaining my own fork.

dr460nf1r3 commented 1 year ago

Sounds good to me!

dr460nf1r3 commented 1 year ago

Eh I noticed you actually did it. Nice to see! :)

SFort commented 9 months ago

Could we please get this in the main package, it feels very silly having to spend way more time compiling a separate build of a browser, specificly for installing a thrown together addon.

stefanwimmer128 commented 9 months ago

Compiling is not necessary since the package is either available prebuilt as firedragon-unsigned-extensions-bin or in my own repository or can be manually downloaded from my GitLab.

SFort commented 9 months ago

Still, extensions are a basic function, they shouldn't need a special version of a browser. although thanks for pointing out there's a -bin package, i do need it

stefanwimmer128 commented 5 months ago

Latest versions now allow installation of unsigned extensions by default.

dr460nf1r3 commented 5 months ago

Yes indeed, thanks for taking care!