search

dr4fters / dr4ft

Multiplayer Online MTG Draft and Sealed Simulator
https://dr4ft.info/
MIT License
106 stars 61 forks source link

Missing Battlebond BBD for use with cube #120

Closed impromptuu closed 5 years ago

impromptuu commented 5 years ago

Unable to start a room with a cube list with two BBD cards.

HerveH44 commented 5 years ago

Hi, As a matter of fact, our card database mostly depends on MTGJSON work. It may be better to post an issue over there. As soon as the cards are in the Allsets.json it should solve itself!

Hervé

impromptuu commented 5 years ago

As far as I'm aware, BBD has been on mtgjson since June, 2 2018.

HerveH44 commented 5 years ago

Ok, so it should be the maintainer of the website that should take care of the update of the cards. What site do you use?

tooomm commented 5 years ago

Can you tell if the same problem exist with Commander sets? @impromptuu

tooomm commented 5 years ago

@impromptuu can you try if your cube with BBD cards works for you on this test page? https://beta-dr4ft-pr-136.herokuapp.com/

tooomm commented 5 years ago

It looks like there is a problem indeed @HerveH44

If you take this cube it'll work just fine. But when you replace one card with a BBD card like Archfiend of Despair it'll give you an error:

invalid cards: archfiend of despair

HerveH44 commented 5 years ago

Yeah in fact we don't keep the BBD cards. I'll make a PR for it. Question: should it also be drafted ? I mean, we don't have any TwoHeaded mod ... I'd say it should be kept for a future feature.

HerveH44 commented 5 years ago

@impromptuu you can test there : https://beta-dr4ft-pr-138.herokuapp.com/ with your cube list?

impromptuu commented 5 years ago

@HerveH44 My cube list works for the link provided. Cube list used here @tooomm I've found no issues with commander sets with a little testing. Only the battlebond set.

impromptuu commented 5 years ago

@HerveH44 As for drafting, it should probably only show up in chaos, as there is no current way to implement battlebond-style drafting. If that is even worth it with the need to implement the partners in packs the way Wizards did.

tooomm commented 5 years ago

Cool, thanks for letting us know.

Having real Two-Headed Giant drafts would require some more changes, true.

tooomm commented 5 years ago

Fixed in #169