search

dr4fters / dr4ft

Multiplayer Online MTG Draft and Sealed Simulator
https://dr4ft.info/
MIT License
107 stars 61 forks source link

Improvements to Spoiler sets #432

Open tooomm opened 5 years ago

tooomm commented 5 years ago

Spoiler sets should be in their own category and not pre-selected in any situation. Personally I think they should not be present at all unless fully spoiled because there is no real use in playing a draft with them.

Does it make sense to drop all sets which have a smaller card count than their base or total set size? Or at least use that indication to place them in a spoiler group in the dropdown selection and prevent them from being pre-selected for new users?

HerveH44 commented 5 years ago

@ZeldaZach could you set a field on MTGJson to indicate if a SET is still in "Spoiler" time or full? We could filter on it then and not show it on the list

ZeldaZach commented 5 years ago

I'll work on it. Open a ticket there

tooomm commented 5 years ago

Reply from @ZeldaZach on closing the request at mtgjson:

Thought about it some more: In my opinion there is no real need for such a thing. The following query can detect if a set is fully released or not:

if releaseDate > NOW then spoiler is true

I'd recommend dr4ft to modify their code to accommodate for this

tooomm commented 5 years ago

Could you set a field on MTGJson to indicate if a SET is still in "Spoiler" time or full? We could filter on it then and not show it on the list

This is now availalbe in 4.5.0: "isPartialPreview to denote a set is in spoiler mode and may not be complete"

tooomm commented 3 years ago

Reopening this again to raise attention to the still persistent issue of incomplete spoiler sets being part of the set selection. Did not open a new issue as there are already important information on that topic gathered here in context.

Currently, Strixhaven: School of Mages (STX) (with only 5 cards spoiled) is already available at dr4ft. 🙄

We should discard sets with isPartialPreview=true.