search

dr5hn / countries-states-cities-database

🌍 Discover our global repository of countries, states, and cities! 🏙️ Get comprehensive data in JSON, SQL, PSQL, XML, YAML, and CSV formats. Access ISO2, ISO3 codes, country code, capital, native language, timezones (for countries), and more. #countries #states #cities
https://dr5hn.github.io/countries-states-cities-database/
Open Data Commons Open Database License v1.0
6.83k stars 2.45k forks source link

add: regions database table #657

Closed Freelenzer closed 10 months ago

Freelenzer commented 11 months ago

This add first implementation of region/continents

i will add a PR for Subregions later.

What else needs to be done here?

What can we add to regions? Timezones?

dr5hn commented 10 months ago

@Freelenzer Thank you for your hard work on this! I really appreciate it.

Can we please keep the region and subregion columns as is so they stay backwards compatible?

Also, can you please migrate the updates of the regions, subregions table and countries table within world.sql?

The JSON, CSV, XML & YAML formats will get autogenerated once this PR is merged. You don't have to worry about them.

dr5hn commented 10 months ago

@Freelenzer Can you please migrate the updates of the regions, subregions table and countries table within world.sql?

Freelenzer commented 10 months ago

Yes Im on it 👍 Was just interrupted this morning 🌅

Freelenzer commented 10 months ago

@dr5hn changes are commited now :)

dr5hn commented 10 months ago

@Freelenzer Thanks for that! Can you please remove the countries.sql file updates? That file will be automatically generated.

dr5hn commented 10 months ago

@Freelenzer Also, if you can integrate subregions table, that would be great.

Freelenzer commented 10 months ago

@dr5hn Ok done.

I will do another PR for the subregions. First finish this :)

This is the draft:

https://github.com/dr5hn/countries-states-cities-database/pull/668