search

dracc / NevolutionX

Original Xbox dashboard created with nxdk
MIT License
123 stars 21 forks source link

Applies clang format #96

Closed abaire closed 3 years ago

abaire commented 3 years ago

Applies the .clang-format file added in #95

abaire commented 3 years ago

I tried to minimize changes, but using clang-format 10.0 has some rougher grained options that lead to a few compromises (e.g., never allowing {} on a single line because it'll also do that in places that end up looking unusual, in my opinion)

Note: I chose 10.0 as the lowest common denominator because it's the version easily available on WSL2. I had initially used 12.0.1 on macOS and it looks like Debian/Ubuntu have 12.x in the latest releases as well.

dracc commented 3 years ago

This was an eye opener, for sure. I write ugly code! :joy:

Thanks! :+1:

abaire commented 3 years ago

:) Without automated style enforcement I think inconsistencies slip through no matter how careful we are. I'll send you a followup w/ a pre-commit hook to run the formatter as well and will look into a git workflow to check it server-side.