search

drachels / moodle-mod_diary

A daily diary activity for Moodle.
4 stars 6 forks source link

Missing 'privacy:metadata:diary_entries:title' identifier #41

Open ctam opened 2 months ago

ctam commented 2 months ago

In Moodle 4.3, this plugin (v3.8.0) causes a core unit test error as follows:


Unexpected debugging() call detected.
Debugging: Invalid get_string() identifier: 'privacy:metadata:diary_entries:title' or component 'mod_diary'. Perhaps you are missing $string['privacy:metadata:diary_entries:title'] = ''; in mod/diary/lang/en/diary.php?
* line 356 of /lib/classes/string_manager_standard.php: call to debugging()
* line 7515 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
* line 132 of /admin/tool/dataprivacy/classes/metadata_registry.php: call to get_string()
* line ? of unknownfile: call to tool_dataprivacy\metadata_registry->tool_dataprivacy\{closure}()
* line 129 of /admin/tool/dataprivacy/classes/metadata_registry.php: call to array_map()
* line 62 of /admin/tool/dataprivacy/classes/metadata_registry.php: call to tool_dataprivacy\metadata_registry->format_metadata()
* line ? of unknownfile: call to tool_dataprivacy\metadata_registry->tool_dataprivacy\{closure}()
* line 107 of /admin/tool/dataprivacy/classes/metadata_registry.php: call to array_map()
* line 35 of /admin/tool/dataprivacy/tests/metadata_registry_test.php: call to tool_dataprivacy\metadata_registry->get_registry_metadata()
* line 51 of /admin/tool/dataprivacy/tests/metadata_registry_test.php: call to tool_dataprivacy\metadata_registry_test->get_meta_data()
* line 1548 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to tool_dataprivacy\metadata_registry_test->test_get_registry_metadata_count()
* line 1154 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestCase->runTest()
* line 81 of /lib/phpunit/classes/advanced_testcase.php: call to PHPUnit\Framework\TestCase->runBare()
* line 728 of /vendor/phpunit/phpunit/src/Framework/TestResult.php: call to advanced_testcase->runBare()
* line 904 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestResult->run()
* line 675 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestCase->run()
* line 675 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
* line 675 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
* line 653 of /vendor/phpunit/phpunit/src/TextUI/TestRunner.php: call to PHPUnit\Framework\TestSuite->run()
* line 144 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\TestRunner->run()
* line 97 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\Command->run()
* line 98 of /vendor/phpunit/phpunit/phpunit: call to PHPUnit\TextUI\Command::main()
* line 122 of /vendor/bin/phpunit: call to include()

/home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:89```
drachels commented 2 months ago

That string was added a few days ago to the branch, MOODLE_380_RC4, but I have a couple of other bugs that still need work before I can publish a new version. Meanwhile, you could just copy the language file or copy the string, line 348, and put it in to your file.