search

drachels / moodle-mod_mootyper

4 stars 18 forks source link

Missing completion information on view page #102

Closed PhMemmel closed 2 years ago

PhMemmel commented 2 years ago

The mootyper view doesn't show any activity completion information. I'm not sure if this is intentional or not, but it has the following downside:

If the course setting "Show activity completion conditions" is set to "no" and a mootyper activity's completion is set to "manual", there is no way to see and - even worse - set the completion status of this activity (which again could be troublesome if other activities depend on the completion of this one).

So the activity information should be shown on view.php

drachels commented 2 years ago

Hmm, what you have provided in your pull request is fine if the MooTyper is an exam. However, if it is a lesson with multiple exercises, for any version of rating, it shows as being completed after completing only one exercise. So, I think it is going to need some more work for that situation, and show completed only when all the exercises have been successfully completed.

I am currently working on another plugin and will get to this as soon as I can.

PhMemmel commented 2 years ago

As far as I'm understanding what I did there: ;-)

What I am providing is just adding the button (in case of manual completion) or the completion status labels (if automatic completion is being selected for activity completion). If these labels are showing other completion states than they should as far as I understand this is a different issue?

drachels commented 2 years ago

Been doing some research and I think the way to go will be to try and come up with a new custom completion to handle this.

PhMemmel commented 2 years ago

Thank you for that. Are you talking about the completion information display or do you want to implement some additional specific conditions which have to be met by the activity to be regarded as "completed"?

In case of the latter one: Do you agree that this is a different issue than the one I was reporting here? Does my PR fix the problem of no completion status being shown at all in your opinion?

drachels commented 2 years ago

Yes the latter and for sure it is a different issue. Both Lesson and Practice modes show complete with just ONE exercise being completed. So, I need to create another completion criteria that shows Complete only when ALL the exercises of a Lesson are completed. Your PR fixes the problem of no completion status being shown at all. Thanks for the fix.

PhMemmel commented 2 years ago

Fixed via c6621e78d63baa57a63807b0d7ed540dbdfb0a1d